Add indextts snippet #1373
Add indextts snippet #1373
Conversation
Deep-unlearning
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
There was a problem hiding this comment.
Hey @Deep-unlearning, thanks for opening this PR! It looks really good already. Just left some comments to make the snippet more self-contained and future-proof.
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
There was a problem hiding this comment.
Approving but let's wait for https://huggingface.co/IndexTeam/Index-TTS to be correctly tagged before merging :)
(@Deep-unlearning can you ping here once it's the case?)
| repoName: "IndexTTS", | ||
| repoUrl: "https://github.com/index-tts/index-tts", | ||
| snippets: snippets.indextts, | ||
| filter: false, |
There was a problem hiding this comment.
| filter: false, |
Default value, I think.
There was a problem hiding this comment.
but we put false for all of the ones we don't want so prolly okay to keep it the way it is, unless we want to make the change for all.
There was a problem hiding this comment.
We have not been consistent AFAIK, but ok.
There was a problem hiding this comment.
yeah to be honest I tend to approve both with or without explicit filter: false without caring much. Happy to review a follow-up PR to harmonize this (removing all unecessary filter: false) but low prio
It is tagged now! https://huggingface.co/models?other=index-tts |
Co-authored-by: Deep-Unlearning <[email protected]> Co-authored-by: Deep-Unlearning <[email protected]> Co-authored-by: Lucain <[email protected]>
No description provided.